32129139: Try jest on yaem

[DamienCassou]

This change is 

[BenjaminVanRyseghem]

Reviewed 6 of 6 files at r1, 2 of 2 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @DamienCassou, @danglotb, @JohanBriglia, @josquindebaz, and @ValentinaVasile)

---

jest.config.mjs line 6 at r1 (raw file):

 */

/** @type {import('jest').Config} */

nit: do we need this line?

[josquindebaz]

Reviewed 6 of 6 files at r1, 2 of 2 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @DamienCassou, @danglotb, @JohanBriglia, and @ValentinaVasile)

---

-- commits line 13 at r3:
🥳

[JohanBriglia]

Reviewed 6 of 6 files at r1, 2 of 2 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @DamienCassou, @danglotb, and @ValentinaVasile)

---

-- commits line 13 at r3:

Previously, josquindebaz (Josquin Debaz) wrote…

🥳

Did you already check how much code coverage we have? 😁

[DamienCassou]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @BenjaminVanRyseghem, @danglotb, and @ValentinaVasile)

---

-- commits line 13 at r3:

Previously, JohanBriglia wrote…

Did you already check how much code coverage we have? 😁

You can check that yourself in the CI results.

---

jest.config.mjs line 6 at r1 (raw file):

Previously, BenjaminVanRyseghem (Benjamin Van Ryseghem) wrote…

nit: do we need this line?

We don't need it but it's going to be convenient for anyone using LSP (including VS code and Emacs): it provides completion and documentation.

[BenjaminVanRyseghem]

Reviewed 6 of 6 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @DamienCassou, @danglotb, and @ValentinaVasile)

---

jest.config.mjs line 6 at r1 (raw file):

Previously, DamienCassou (Damien Cassou) wrote…

We don't need it but it's going to be convenient for anyone using LSP (including VS code and Emacs): it provides completion and documentation.

ok, thanks

[BenjaminVanRyseghem]

Reviewed 10 of 10 files at r6, 1 of 1 files at r7, 9 of 9 files at r8, 1 of 1 files at r9, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @DamienCassou, @danglotb, and @ValentinaVasile)

---

babel.config.cjs line 17 at r4 (raw file):

				test: {
					plugins: [
						"rewire",

nit: why removing rewire?

---

test/events.test.js line 109 at r9 (raw file):

	});

	it("un-Bind callback using unbind", () => {

nit: unbinds?

---

test/events.test.js line 175 at r9 (raw file):

	});

	it("event Category can bind callback to named event using register", () => {

nit: shouldn't tests start with a verb?

[DamienCassou]

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @BenjaminVanRyseghem, @danglotb, and @ValentinaVasile)

---

babel.config.cjs line 17 at r4 (raw file):

Previously, BenjaminVanRyseghem (Benjamin Van Ryseghem) wrote…

nit: why removing rewire?

it's not necessary to make the tests pass ;-). I have nothing against adding it back later but I'm keeping the stack as small as possible for now

---

test/events.test.js line 109 at r9 (raw file):

Previously, BenjaminVanRyseghem (Benjamin Van Ryseghem) wrote…

nit: unbinds?

these changes were done automatically by eslint plugins (not yet enabled in this PR because I have a dedicated one in dev-doc). I agree more changes are necessary to make the code follow the guideline. It feels out of scope though.

---

test/events.test.js line 175 at r9 (raw file):

Previously, BenjaminVanRyseghem (Benjamin Van Ryseghem) wrote…

nit: shouldn't tests start with a verb?

definitely. In this case, I think we need a dedicated describe() block and maybe even a dedicated test file. This is out of scope of this PR though. This change was done automatically by eslint. https://github.com/jest-community/eslint-plugin-jest/blob/HEAD/docs/rules/prefer-lowercase-title.md