Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update containers doc #117

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Update containers doc #117

merged 2 commits into from
Oct 30, 2023

Conversation

maestromac
Copy link
Contributor

No description provided.

@maestromac maestromac marked this pull request as ready for review October 26, 2023 19:32
@maestromac maestromac requested a review from a team as a code owner October 26, 2023 19:32
@maestromac maestromac requested review from lightalloy and removed request for a team October 26, 2023 19:32
Copy link

@lightalloy lightalloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool ✨ It's great that we are updating the installation docs.
I left one small comment but looks good in general.

line interface. Podman is available on many different Linux distributions and it
can be installed by following these
[instructions](https://podman.io/getting-started/installation).
Due to the way our we setup our `docker-compose.yml`, standard `docker-compose up` command is not support. Please checkout the "Containerized setup with `dip` gem option"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not supported? (instead of "not support")

Also, not a big deal but as I understood, docker-compose up was replaced by docker compose up

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah right yeah forgot about that

@maestromac maestromac merged commit 1f53c55 into main Oct 30, 2023
6 checks passed
@maestromac maestromac deleted the mac/update-container-docs branch October 30, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants