chore: automated tests for bundled core in apex-node and templates #1070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mingxuanzhangsfdx
requested changes
May 29, 2024
There was a problem hiding this comment.
- fix the bundle and publish workflow. In your current change, the publishing jbo does not wait the bundling job, and they are on separate workspaces actually.
- figure out why there are 2 test failures in templates on windows.
- figure out why prdNuts fails, might need to bump the dependencies and also reach out to CLI when necessary.
- several questions I left.
|
Remember to automate the release of core-bundle as well(I just updated in the AC of the work item) |
build executed only when the previous workflow succeeds or manually
mingxuanzhangsfdx
approved these changes
Jun 3, 2024
WillieRuemmele
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
testCoreBundling.ymlandtestExternalProjects.ymlto automate testing for core bundled in apex-node and templates repoesbuild-publish.ymlinto new workflowbundle.ymlWhat issues does this PR fix or reference?
@W-15634761@
Test run: https://github.com/forcedotcom/sfdx-core/actions/runs/9341655590/job/25708669666?pr=1070 ✅