Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@W-15207087@ Update entry point of the project #1036

Merged
merged 3 commits into from
Mar 19, 2024
Merged

@W-15207087@ Update entry point of the project #1036

merged 3 commits into from
Mar 19, 2024

Conversation

mingxuanzhangsfdx
Copy link
Member

What does this PR do?

  1. Update the entry point of the project from exported.ts to index.ts
  2. Rename the main field and types declaration for the entry point name change
  3. Update the bundling script so that
  • the generated file name aligns with package.json
  • the hardcoded package name for Messages.loadMessages is '@salesforce/core-bundle'

What issues does this PR fix or reference?

@W-15207087@

https://gus.lightning.force.com/lightning/r/ADM_Work__c/a07EE00001lh6OPYAY/view

Due to the limitation of npm-dts the entry file should be index.ts otherwise it will refer to a wrong path of the module in the generated type declarations.

Copy link
Contributor

@shetzel shetzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

@mingxuanzhangsfdx mingxuanzhangsfdx removed the request for review from mshanemc March 13, 2024 18:00
@shetzel shetzel merged commit 2874778 into main Mar 19, 2024
66 checks passed
@shetzel shetzel deleted the mz/W-15207087 branch March 19, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants