test: add NUT for web server

.github/workflows/test.yml

@@ -5,6 +5,15 @@ on:
   workflow_dispatch:
 
 jobs:
+  determine-node-versions:
+    outputs:
+      nodeVersions: ${{ steps.determine-node-versions.outputs.nodeVersions }}
+    runs-on: ubuntu-latest
+    steps:
+      - uses: salesforcecli/github-workflows/.github/actions/determineNodeVersions@main
+        id: determine-node-versions
+        with:
+          nodeVersionOverride: ${{ vars.NODE_VERSION_OVERRIDE }} # default is 'lts/*' and 'lts/-1'
   yarn-lockfile-check:
     uses: salesforcecli/github-workflows/.github/workflows/lockFileCheck.yml@main
   # Since the Windows unit tests take much longer, we run the linux unit tests first and then run the windows unit tests in parallel with NUTs
@@ -14,6 +23,36 @@ jobs:
   windows-unit-tests:
     needs: linux-unit-tests
     uses: salesforcecli/github-workflows/.github/workflows/unitTestsWindows.yml@main
+  sfdx-core-nuts:
+    needs: linux-unit-tests
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4
+        with:
+          node-version: ${{ fromJSON(needs.determine-node-versions.outputs.nodeVersions) }}
+          cache: yarn
+      - uses: google/wireit@setup-github-actions-caching/v1
+        continue-on-error: true
+      - name: Cache node modules
+        id: cache-nodemodules
+        uses: actions/cache@v3
+        env:
+          cache-name: cache-node-modules
+        with:
+          path: '**/node_modules'
+          key: ${{ runner.os }}-build-${{ env.cache-name }}-${{ hashFiles('**/yarn.lock') }}
+
+      - uses: salesforcecli/github-workflows/.github/actions/yarnInstallWithRetries@main
+        if: ${{ steps.cache-nodemodules.outputs.cache-hit != 'true' }}
+      - run: yarn build
+      - name: yarn test:nuts
+        uses: salesforcecli/github-workflows/.github/actions/retry@main
+        with:
+          command: yarn test:nuts
+        env:
+          SF_DISABLE_TELEMETRY: true
+
   xNuts:
     needs: linux-unit-tests
     uses: salesforcecli/github-workflows/.github/workflows/externalNut.yml@main

package.json

@@ -21,6 +21,7 @@
     "prepack": "sf-prepack",
     "prepare": "sf-install",
     "test": "wireit",
+    "test:nuts": "nyc mocha test/**/*.nut.ts",
     "test:only": "wireit",
     "test:perf": "ts-node test/perf/logger/main.test.ts"
   },

src/webOAuthServer.ts

@@ -81,6 +81,11 @@ export class WebOAuthServer extends AsyncCreatable<WebOAuthServer.Options> {
     return this.authUrl;
   }
 
+  public close(): void {
+    this.logger.debug('closing server connection');
+    this.webServer.close();
+  }
+
   /**
    * Executes the oauth request and creates a new AuthInfo when successful
    *

test/nut/webOauthServer.nut.ts

@@ -0,0 +1,43 @@
+/*
+ * Copyright (c) 2024, salesforce.com, inc.
+ * All rights reserved.
+ * Licensed under the BSD 3-Clause license.
+ * For full license text, see LICENSE.txt file in the repo root or https://opensource.org/licenses/BSD-3-Clause
+ */
+import { expect } from 'chai';
+import { WebOAuthServer } from '../../src/webOAuthServer';
+import { JwtOAuth2Config } from '../../src/org/authInfo';
+
+describe('web Oauth server', () => {
+  const oauthConfig: JwtOAuth2Config = {
+    loginUrl: 'https://login.salesforce.com',
+  };
+
+  let oauthServer: WebOAuthServer;
+
+  before(async () => {
+    oauthServer = await WebOAuthServer.create({ oauthConfig });
+    await oauthServer.start();
+    await oauthServer.authorizeAndSave();
+  });
+
+  after(() => {
+    oauthServer.close();
+  });
+
+  it('handle preflight request', async () => {
+    const accessControlHeaders = new Headers({
+      'access-control-request-private-network': 'true',
+      'access-control-request-method': 'GET',
+    });
+
+    const res = await fetch('http://localhost:1717', {
+      method: 'OPTIONS',
+      headers: accessControlHeaders,
+    });
+
+    expect(res.status).to.equal(204);
+    expect(res.headers.get('Access-Control-Allow-Methods')).to.equal('GET');
+    expect(res.headers.get('Access-Control-Request-Headers')).to.equal('GET');
+  });
+});

test/tsconfig.json

@@ -1,6 +1,6 @@
 {
   "extends": "@salesforce/dev-config/tsconfig-test-strict",
-  "include": ["unit/**/*.ts", "perf/**/*.ts"],
+  "include": ["unit/**/*.ts", "nut/**/*.ts", "perf/**/*.ts"],
   "compilerOptions": {
     "noEmit": true,
     "skipLibCheck": true,