Modify apex-node to include new test setup fields and data structure #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peternhale
requested changes
Jun 13, 2024
There was a problem hiding this comment.
@CristiCanizales please add a test to cover the sobject describe logic and its affect on queries that are modified based on those results.
peternhale
requested changes
Jun 19, 2024
peternhale
requested changes
Jun 24, 2024
There was a problem hiding this comment.
@CristiCanizales one more change. Its on me I mislead you on are call.
peternhale
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds new type TestResultRaw to apex-node. This type will be the internal representation of test results in a form that follows the structure of data queried from SOQL (pretty much same as TestResult is now). The new type will need new summary section field testSetupTime as a number.
What issues does this PR fix or reference?
@W-15923080@
Functionality After
TestResultRawis used as the internal data structure for accumulating test resultsTestResultRawtransform toTestResultwill not propagate any of the new test setup data to the API caller.Extra: