Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support interrupt on Windows soon! #2659

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Support interrupt on Windows soon! #2659

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ HTTP = "^1.5.2"
HypertextLiteral = "0.7, 0.8, 0.9"
LoggingExtras = "0.4, 1"
MIMEs = "0.1"
Malt = "1.0.3"
Malt = "1.1"
MsgPack = "1.1"
PrecompileSignatures = "3"
PrecompileTools = "1"
Expand Down
6 changes: 2 additions & 4 deletions src/evaluation/WorkspaceManager.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -641,10 +641,8 @@ function interrupt_workspace(session_notebook::Union{SN,Workspace}; verbose=true
return true
end

if Sys.iswindows()
verbose && @warn "Unfortunately, stopping cells is currently not supported on Windows :(
Maybe the Windows Subsystem for Linux is right for you:
https://docs.microsoft.com/en-us/windows/wsl"
if (workspace.worker isa Malt.DistributedStdlibWorker) && Sys.iswindows()
verbose && @warn "Stopping cells is not yet supported on Windows, but it will be soon!\n\nYou can already try out this new functionality with:\n\nPluto.run(workspace_use_distributed_stdlib=false)\n\nLet us know what you think!"
return false
end

Expand Down
Loading