Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Without distributed #1854

Closed
wants to merge 31 commits into from
Closed

Without distributed #1854

wants to merge 31 commits into from

Conversation

dralletje
Copy link
Collaborator

@dralletje dralletje commented Jan 25, 2022

It works!

But it is a bit slower than Distributed..
Not so much you notice it while running normally, but you do notice it when dragging a bind-ed slider :/

@github-actions
Copy link
Contributor

Try this Pull Request!

Open Julia and type:

julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/fonsp/Pluto.jl", rev="without-distributed")
julia> using Pluto

@fonsp fonsp linked an issue Jan 26, 2022 that may be closed by this pull request
@Pangoraw
Copy link
Collaborator

Awesome Work! Do you have any idea why it might be slower than Distributed ? Maybe it is the pipes buffering being slower than the socket Distributed is using ?

PS: For anyone wanting to see the code in the notebooks:

@fonsp
Copy link
Owner

fonsp commented Feb 1, 2022

We don't know why it is slower than distributed, but we do know that Distributed uses a TCP server (Sockets stdlib) to talk server-worker, while we use stdin/stdout. I think that we should also use TCP, do the benchmark again and reevaluate.

I tried to get a server-worker communication working with the Sockets stdlib, but it was surprisingly difficult... Avik mentioned https://github.com/JuliaInterop/ZMQ.jl today (in another context), which is apparently working very well, and I believe that IJulia.jl also uses it. So maybe we should use ZMQ.jl instead of writing our own TCP server/client!

(If anyone wants to give this a try, write a comment so that we don't end up working on it at the same time)

@fonsp fonsp marked this pull request as draft February 3, 2022 11:29
@fonsp fonsp closed this Jun 15, 2022
@fonsp fonsp mentioned this pull request Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow using Distributed
3 participants