-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(config): provide user callback on live reload #87
Open
Ajaymamtora
wants to merge
6
commits into
folke:main
Choose a base branch
from
Ajaymamtora:feature/callback_live_reload
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ajaymamtora
changed the title
feat(config) provide user callback on live reload
feat(config): provide user callback on live reload
Aug 24, 2024
This PR is stale because it has been open 30 days with no activity. |
. |
This PR is stale because it has been open 30 days with no activity. |
. |
This PR is stale because it has been open 30 days with no activity. |
. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It's useful to be able to do some work once the plugin has live_reloaded after a local or global config file has been written to.
For example: I define a list of "exclusions" similar to IntelliJ so that files and folders that match this pattern, are excluded from text searches, the folder is marked as excluded in the file tree etc. In IntelliJ this takes effect immediately when you mark a file or folder as excluded.
I'd like to mimic this behaviour using this plugin, so by providing a callback, I can do so.
Telescope defines these exclusions in
config.defaults.file_ignore_patterns
. So with this callback, I can call the setup function again by setting this value with the newly updated value from neoconf via.get("exclusions")
.This is just a simple example, there are many applications for this callback.
#65
Related Issue(s)
#65
Screenshots