Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIU-3273: check if userId is present in withUserRoles HOC #2816

Merged
merged 4 commits into from
Dec 3, 2024
Merged

UIU-3273: check if userId is present in withUserRoles HOC #2816

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
77cb21a
UIU-3273: check if userId is present in withUserRoles HOC
aidynoJ Dec 2, 2024
17d6cd6
Changelog
aidynoJ Dec 2, 2024
b4d5859
Merge branch 'master' into UIU-3273
aidynoJ Dec 3, 2024
8ed588f
Merge branch 'master' into UIU-3273
aidynoJ Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@
* Leverage API supported sorting of columns on pre-registrations records list. Refs UIU-3249.
* Add permission to access users-keycloak delete method. Refs UIU-3282.
* Fix issue with `Proxy borrower` field value. Refs UIU-3290.
* Check if userId is present in withUserRoles HOC. Refs UIU-3273.



## [11.0.7](https://github.com/folio-org/ui-users/tree/v11.0.7) (2024-11-30)
[Full Changelog](https://github.com/folio-org/ui-users/compare/v11.0.6...v11.0.7)
Expand Down
2 changes: 1 addition & 1 deletion src/components/Wrappers/withUserRoles.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ const withUserRoles = (WrappedComponent) => (props) => {

useEffect(() => {
// eslint-disable-next-line react/prop-types
if (props.stripes.hasInterface('users-keycloak') && !isAllRolesDataLoading) {
if (props.stripes.hasInterface('users-keycloak') && !isAllRolesDataLoading && !!userId) {
api.get(
'roles/users', { searchParams },
)
Expand Down
Loading