Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UIIN-2888: React 19: refactor away from react-dom/test-utils #2688

Merged
merged 3 commits into from
Dec 4, 2024
Merged

UIIN-2888: React 19: refactor away from react-dom/test-utils #2688

merged 3 commits into from
Dec 4, 2024

Conversation

OleksandrHladchenko1
Copy link
Contributor

Approach

  • Use act from @folio/jest-config-stripes/testing-library/react instead of react-dom/test-utils

Refs

UIIN-2888

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024 •
edited
Loading

Jest Unit Test Statistics

       1 files  ±0     253 suites  ±0   14m 24s ⏱️ -4s
1 015 tests ±0  1 013 ✔️ ±0  2 💤 ±0  0 ❌ ±0 
1 022 runs  ±0  1 020 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit c06bb41. ± Comparison against base commit 1bb3c4c.

♻️ This comment has been updated with latest results.

zburke
zburke approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@zburke zburke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the clean up effort!

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@OleksandrHladchenko1 OleksandrHladchenko1 merged commit 0aafbc2 into master Dec 4, 2024
5 checks passed
@OleksandrHladchenko1 OleksandrHladchenko1 deleted the UIIN-2888 branch December 4, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariia-aloshyna mariia-aloshyna mariia-aloshyna approved these changes

@zburke zburke zburke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OleksandrHladchenko1 @zburke @mariia-aloshyna