UIIN-3137: Add the isSearchToggleHitInBrowse flag to the history state to use in the condition that specifies whether to use the default sort on mount.
#2682
Conversation
…e to use in the condition that specifies whether to use the default sort on mount.
Dmytro-Melnyshyn
requested review from
BogdanDenis,
mariia-aloshyna,
OleksandrHladchenko1 and
a team
Dmytro-Melnyshyn
force-pushed
the
UIIN-3137
branch
from
7ece690
to
5ec2722
Compare
|
There was a problem hiding this comment.
@Dmytro-Melnyshyn, this PR fixes one bug (losing state when toggling between search and browse) but introduces another in its place (losing state when toggling between this application and another).
The screen-capture shows ui-inventory navigating from its default state [A], (sort: title) to a new state [B] (sort: contributor), out to another app, and then navigating back to ui-inventory. At this point, ui-inventory state should reflect [B], but it's [A]. This is incorrect, and not how other applications act.
Please review the requested functionality with your PO before you merge. I'm happy to be involved in the discussion if there are questions about how application state should be preserved across navigation actions.
Purpose
Use previously applied sorting after switching from Browse search by pressing the Search toggle.
Approach
Add a flag to
history.statewhen hitting the Search toggle in Browse search, and use it to determine whether to use default sorting.Refs
UIIN-3137
Screenshots
2024-11-29_15h43_06.mp4