Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIIN-2890: React v19: refactor away from default props for functional components #2673

Merged
merged 4 commits into from
Nov 25, 2024

Conversation

mariia-aloshyna
Copy link
Contributor

Purpose

refactor away from default props for functional components

Approach

  • Remove defaultProps from functional components

Refs

https://folio-org.atlassian.net/browse/UIIN-2890

Screenshots

Copy link

github-actions bot commented Nov 21, 2024

Jest Unit Test Statistics

       1 files  ±0     253 suites  ±0   14m 36s ⏱️ -10s
1 014 tests ±0  1 012 ✔️ ±0  2 💤 ±0  0 ±0 
1 021 runs  ±0  1 019 ✔️ ±0  2 💤 ±0  0 ±0 

Results for commit 7eaf7a8. ± Comparison against base commit d1a545f.

♻️ This comment has been updated with latest results.

Copy link

sonarcloud bot commented Nov 25, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
73.0% Coverage on New Code (required ≥ 80%)
3.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@mariia-aloshyna mariia-aloshyna merged commit 28df52d into master Nov 25, 2024
4 of 5 checks passed
@mariia-aloshyna mariia-aloshyna deleted the UIIN-2890 branch November 25, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants