Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIIN-3124 cautiously evaluate subPermissions in hasMemberTenantPermission #2667

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

zburke
Copy link
Member

@zburke zburke commented Nov 12, 2024

Use optional chaining when evaluating subPermissions to avoid potential NPEs if a permission does not have any subPermissions.

Refs UIIN-3124

Use optional chaining when evaluating subpermissions to avoid potential
NPEs if a permission does not have any subpermissions.

Refs UIIN-3124
Copy link

github-actions bot commented Nov 12, 2024

Jest Unit Test Statistics

       1 files  ±0     254 suites  ±0   14m 46s ⏱️ -37s
1 021 tests +6  1 019 ✔️ +6  2 💤 ±0  0 ±0 
1 028 runs  +6  1 026 ✔️ +6  2 💤 ±0  0 ±0 

Results for commit 03f3a86. ± Comparison against base commit db50c79.

♻️ This comment has been updated with latest results.

Copy link

sonarcloud bot commented Nov 13, 2024

@zburke zburke merged commit fa58639 into master Nov 13, 2024
5 checks passed
@zburke zburke deleted the UIIN-3124 branch November 13, 2024 11:35
Dmytro-Melnyshyn pushed a commit that referenced this pull request Nov 15, 2024
Use optional chaining when evaluating permissions to avoid potential
NPEs if a permission does not have a `subPermissions` attribute.

Refs UIIN-3124
BogdanDenis pushed a commit that referenced this pull request Nov 15, 2024
Use optional chaining when evaluating permissions to avoid potential
NPEs if a permission does not have a `subPermissions` attribute.

Refs UIIN-3124
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants