Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIIN-3113: ECS | Instance details pane does not contain all tenants when user does not have affiliations / permissions in all tenants #2664

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

mariia-aloshyna
Copy link
Contributor

Purpose

Consortial holdings accordion is empty for shared instance if a user does not have affiliations/permissions.

Approach

  • Fix checking of empty holdings array for limited holdings info.

Refs

https://folio-org.atlassian.net/browse/UIIN-3113

Screenshots

…hen user does not have affiliations / permissions in all tenants
Copy link

github-actions bot commented Nov 8, 2024

Jest Unit Test Statistics

       1 files  ±0     254 suites  ±0   14m 35s ⏱️ -15s
1 015 tests ±0  1 013 ✔️ ±0  2 💤 ±0  0 ±0 
1 022 runs  ±0  1 020 ✔️ ±0  2 💤 ±0  0 ±0 

Results for commit c4059b8. ± Comparison against base commit 317969f.

♻️ This comment has been updated with latest results.

@mariia-aloshyna
Copy link
Contributor Author

@Dmytro-Melnyshyn @BogdanDenis please take a look

Copy link

sonarcloud bot commented Nov 12, 2024

@mariia-aloshyna mariia-aloshyna merged commit db50c79 into master Nov 13, 2024
5 checks passed
@mariia-aloshyna mariia-aloshyna deleted the UIIN-3113 branch November 13, 2024 10:54
Dmytro-Melnyshyn pushed a commit that referenced this pull request Nov 15, 2024
…hen user does not have affiliations / permissions in all tenants (#2664)
mariia-aloshyna added a commit that referenced this pull request Nov 22, 2024
…hen user does not have affiliations / permissions in all tenants (#2664)

(cherry picked from commit db50c79)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants