Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UIIN-3102: The item cannot be moved to another holdings associated with another instance #2663

Merged
merged 2 commits into from
Nov 8, 2024
Merged

UIIN-3102: The item cannot be moved to another holdings associated with another instance #2663

merged 2 commits into from
Nov 8, 2024

Conversation

OleksandrHladchenko1
Copy link
Contributor

Purpose

  • The item should be moved to the holdings of another instance and displayed in the "Holdings" accordion, but the message "1 item has been successfully moved." appeared and the item was not actually moved.

Approach

  • If user moves holdings then set to movingItems holdings ids, otherwise - items ids.
  • Check if holdingIds is empty in checkHasMultiplePOLsOrHoldings function. Previously, when holdingIds was empty, it returned all the PO lines not related to current instance.

Refs

UIIN-3102

Screenshots

UIIN-3102.mp4

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024 •
edited
Loading

Jest Unit Test Statistics

       1 files  ±0     254 suites  ±0   14m 29s ⏱️ - 3m 13s
1 015 tests ±0  1 013 ✔️ +2  2 💤 ±0  0 ❌  - 2 
1 022 runs  ±0  1 020 ✔️ +2  2 💤 ±0  0 ❌  - 2 

Results for commit 1260b8a. ± Comparison against base commit 3e36a66.

♻️ This comment has been updated with latest results.

Terala-Priyanka
Terala-Priyanka reviewed Nov 7, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 7, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@OleksandrHladchenko1 OleksandrHladchenko1 merged commit a31e89a into master Nov 8, 2024
4 of 5 checks passed
@OleksandrHladchenko1 OleksandrHladchenko1 deleted the UIIN-3102 branch November 8, 2024 09:09
Dmytro-Melnyshyn pushed a commit that referenced this pull request Nov 15, 2024
@OleksandrHladchenko1 @Dmytro-Melnyshyn
UIIN-3102: The item cannot be moved to another holdings associated wi…
4c89ad3 
…th another instance (#2663)

* UIIN-3102: The item cannot be moved to another holdings associated with another instance

* Update CHANGELOG.md
BogdanDenis pushed a commit that referenced this pull request Nov 15, 2024
@OleksandrHladchenko1 @BogdanDenis
UIIN-3102: The item cannot be moved to another holdings associated wi…
dcb5bd0 
…th another instance (#2663)

* UIIN-3102: The item cannot be moved to another holdings associated with another instance

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariia-aloshyna mariia-aloshyna mariia-aloshyna approved these changes

@BogdanDenis BogdanDenis BogdanDenis approved these changes

@Terala-Priyanka Terala-Priyanka Awaiting requested review from Terala-Priyanka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@OleksandrHladchenko1 @BogdanDenis @mariia-aloshyna @Terala-Priyanka