UIIN-3099: Run history.replace once during component mount and update to avoid URL rewriting.
#2662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to avoid URL rewriting.
Dmytro-Melnyshyn
requested review from
BogdanDenis,
mariia-aloshyna,
OleksandrHladchenko1 and
a team
|
mariia-aloshyna
approved these changes
Nov 1, 2024
BogdanDenis
approved these changes
Nov 1, 2024
BogdanDenis
pushed a commit
that referenced
this pull request
Nov 15, 2024
… to avoid URL rewriting. (#2662)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Send
staffSuppressfilter andsortvalue in URL at the same time to avoid rewriting during mount and update.Approach
Set the necessary search params in
const searchParams = new URLSearchParams(location.search);and only then dohistory.replace.Refs
UIIN-3099
Screenshots
2024-11-01_14h58_47.mp4