Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIIN-3021: Provide necessary props for browse lookup facets. Remove the facets state reset functionality. #2615

Merged
merged 49 commits into from
Nov 15, 2024

Conversation

Dmytro-Melnyshyn
Copy link
Contributor

@Dmytro-Melnyshyn Dmytro-Melnyshyn commented Oct 4, 2024

Description

Most of the facets will be replaced with the MultiSelection component, the main work is done in the related PR. This PR contains minor changes:

  • provided the necessary properties for Browse lookup facets;
  • removed the facets state reset functionality, since it is no longer relevant for the new facets functionality;
  • removed the MultiSelectionFacet component, which is used only for the Name type facet, for which the NameTypeFacet component is created.

Related PRs

folio-org/stripes-inventory-components#79

Approach

Refs

UIIN-3021

Screenshots

2024-10-04_17h21_28.mp4

Copy link

github-actions bot commented Oct 4, 2024

Jest Unit Test Statistics

       1 files  ±0     253 suites   - 1   15m 10s ⏱️ +42s
1 014 tests  - 7  1 012 ✔️  - 7  2 💤 ±0  0 ±0 
1 021 runs   - 7  1 019 ✔️  - 7  2 💤 ±0  0 ±0 

Results for commit c038a4f. ± Comparison against base commit 8b9ad01.

♻️ This comment has been updated with latest results.

ryandberger and others added 25 commits November 14, 2024 20:18
…ARC instances in Inventory on member tenant (#2642)

* UIIN-3097 Add null safety to prevent error screen

* Lint fix

* Syntax fix

* Fix default value
* UIIN-3046: fix page refreshing issue

* improve the selection logic
…th another instance (#2663)

* UIIN-3102: The item cannot be moved to another holdings associated with another instance

* Update CHANGELOG.md
…hen user does not have affiliations / permissions in all tenants (#2664)
Use optional chaining when evaluating permissions to avoid potential
NPEs if a permission does not have a `subPermissions` attribute.

Refs UIIN-3124
Copy link

sonarcloud bot commented Nov 15, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
75.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@Dmytro-Melnyshyn Dmytro-Melnyshyn merged commit 343bc3c into master Nov 15, 2024
4 of 5 checks passed
@Dmytro-Melnyshyn Dmytro-Melnyshyn deleted the UIIN-3021 branch November 15, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.