Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIIN-2636: Replace imports from quick-marc with stripes-marc-components. #2320

Merged
merged 4 commits into from
Oct 31, 2023

Conversation

Dmytro-Melnyshyn
Copy link
Contributor

@Dmytro-Melnyshyn Dmytro-Melnyshyn commented Oct 24, 2023

Purpose

Replace imports from quick-marc with stripes-marc-components.

Related PRs

folio-org/stripes-marc-components#4

Approach

Refs

UIIN-2636

Screenshots

@github-actions
Copy link

github-actions bot commented Oct 24, 2023

Jest Unit Test Statistics

    1 files  ±0  226 suites  ±0   16m 31s ⏱️ + 1m 21s
888 tests ±0  886 ✔️ ±0  2 💤 ±0  0 ±0 
893 runs  ±0  891 ✔️ ±0  2 💤 ±0  0 ±0 

Results for commit f4b802e. ± Comparison against base commit e83ab07.

♻️ This comment has been updated with latest results.

@Dmytro-Melnyshyn Dmytro-Melnyshyn changed the title UIIN-2636: Import MarcView from stripes-marc-components. UIIN-2636: Replace imports from quick-marc with stripes-marc-components. Oct 24, 2023
CHANGELOG.md Outdated
@@ -3,6 +3,7 @@

## [10.1.0] IN PROGRESS

* Replace imports from quick-marc with stripes-marc-components. Refs UIIN-2636.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump up major version and add a Breaking change note in changelog

Copy link

sonarcloud bot commented Oct 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Dmytro-Melnyshyn Dmytro-Melnyshyn merged commit 9fcfe3e into master Oct 31, 2023
5 checks passed
@Dmytro-Melnyshyn Dmytro-Melnyshyn deleted the UIIN-2636 branch October 31, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants