-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UIIN-2636: Replace imports from quick-marc with stripes-marc-components. #2320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dmytro-Melnyshyn
force-pushed
the
UIIN-2636
branch
from
October 24, 2023 12:23
3ec96c0
to
ac7a82a
Compare
Dmytro-Melnyshyn
force-pushed
the
UIIN-2636
branch
from
October 24, 2023 12:41
ac7a82a
to
60667eb
Compare
Dmytro-Melnyshyn
changed the title
UIIN-2636: Import MarcView from stripes-marc-components.
UIIN-2636: Replace imports from quick-marc with stripes-marc-components.
Oct 24, 2023
BogdanDenis
approved these changes
Oct 25, 2023
BogdanDenis
requested changes
Oct 26, 2023
CHANGELOG.md
Outdated
@@ -3,6 +3,7 @@ | |||
|
|||
## [10.1.0] IN PROGRESS | |||
|
|||
* Replace imports from quick-marc with stripes-marc-components. Refs UIIN-2636. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please bump up major version and add a Breaking change note in changelog
BogdanDenis
approved these changes
Oct 26, 2023
Dmytro-Melnyshyn
requested review from
mariia-aloshyna and
OleksandrHladchenko1
October 26, 2023 14:09
mariia-aloshyna
approved these changes
Oct 26, 2023
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Replace imports from
quick-marc
withstripes-marc-components
.Related PRs
folio-org/stripes-marc-components#4
Approach
Refs
UIIN-2636
Screenshots