UIAC-63 Introduce new permission to view all acquisition unit settings #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zburke
approved these changes
Aug 31, 2023
There was a problem hiding this comment.
Ideally there should be a test that shows a the actions menu is populated/empty when these permissions are/are not present.
FYI, your build is failing due to rehooks/local-storage/issues/103 but you can work around this via UIAC-70 which needs to be done for Poppy anyway.
| @@ -37,13 +37,15 @@ const AcquisitionUnitDetails = ({ acquisitionUnit, close, getEditPath, deleteUni | |||
| const stripes = useStripes(); | |||
|
|
|||
| const getActionMenu = () => { | |||
| return ( | |||
| const isPermittedToViewActions = stripes.hasPerm('acquisitions-units.units.item.put') || stripes.hasPerm('acquisitions-units.units.item.delete'); | |||
There was a problem hiding this comment.
It's better to utilize UI permissions instead of BE ones in stripes.hasPerm/IfPermission. In this case, the user will not accidentally get access to functionality they shouldn't from another UI permission assigned to them.
Dmytro-Melnyshyn
approved these changes
Aug 31, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
https://issues.folio.org/browse/UIAC-63
Approach
Add permission to ONLY view all settings in the
acquisition-unitsand protect actions from non-permitted user.Screencast
chrome_kQZAauxoaG.mp4
Pre-Merge Checklist
Before merging this PR, please go through the following list and take appropriate actions.
If there are breaking changes, please STOP and consider the following:
Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.