-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C409495: Filters section: Users filter (Firebird) (TaaS) #2416
base: master
Are you sure you want to change the base?
Conversation
|
…/github.com/folio-org/stripes-testing into FIX-C_-409495]_Filters_Section_Users_filter
Please, add a screenshot from Jenkins run. Not local |
@@ -0,0 +1,43 @@ | |||
import permissions from '../../../support/dictionary/permissions'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, move file to bulk-edit/logs
bulk-edit-filter-section-user-filter-page.cy.js
describe('bulk-edit', () => { | ||
before('create test users', () => { | ||
cy.createTempUser([ | ||
permissions.bulkEditLogsView.gui, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Permissions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what need to be done here? I gave required permissions as per testcase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just code convension Premissions
users.deleteViaApi(user.userId); | ||
}); | ||
|
||
it('Filters section: Users filter', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, add TC id, tags and names for dev teams. See other tests
BulkEditSearchPane.checkHoldingsCheckbox(); | ||
BulkEditSearchPane.checkItemsCheckbox(); | ||
BulkEditSearchPane.checkUsersCheckbox(); | ||
BulkEditSearchPane.verifyLogsTableHeaders(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed some expected results from Step2
Missed lots of expected results. Please add it
@@ -82,6 +87,14 @@ export default { | |||
cy.expect(searchButton.has({ disabled: isDisabled })); | |||
}, | |||
|
|||
xAppearsNextToUser() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
verifyUserAccordionHasXIcon() {
cy.expect(Section({ id: 'userId'}).find(Button({icon: 'times-circle-solid' })).exists())
}
cy.expect(xIconButtonUser.exists()); | ||
}, | ||
|
||
clickOnXAppearsNextToUser() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clearUserAccordion() {
cy.expect(Section({ id: 'userId'}).find(Button({icon: 'times-circle-solid' })).click())
}
cy.do(logsUsersAccordion.find(buttonChooseUser).click()); | ||
}, | ||
|
||
searchUser(name) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
verifyUserIsNotInUserList() {
cy.do([Selection(id...).open(), SelectionList().find(SelectionOption(name)).absent()]);
}
cy.contains('List is empty').should('be.visible'); | ||
cy.contains('No matching option').should('be.visible'); | ||
}, | ||
searchAndSelectUser(name) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cy.do([Selection(id...).open(), SelectionList().select(user)]);
clickChooseUserUnderUserAccordion is redundant
BulkEditSearchPane.verifyLogsTableHeaders(); | ||
BulkEditSearchPane.clickUserAccordion(); | ||
BulkEditSearchPane.clickChooseUserUnderUserAccordion(); | ||
BulkEditSearchPane.searchAndSelectUser('Test_All'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the user 'Test_All'?
I suppose need to create User via API in before section and delete it in after section
See another tests
Users.createViaApi...
cy.login(user.username, user.password, { | ||
path: TopMenu.bulkEditPath, | ||
waiter: BulkEditSearchPane.waitLoading, | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed precondtion from TC
The FOLIO contains completed Bulk Edit jobs, jobs were run by different Users
Ask AQA from Firebird team how to do this (Guliyashnar Nayimova (nayimovag))
Test Rail ID
https://foliotest.testrail.io/index.php?/cases/view/409495