Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C409495: Filters section: Users filter (Firebird) (TaaS) #2416

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

amanepam2023
Copy link
Contributor

@amanepam2023 amanepam2023 commented Nov 22, 2023

@CLAassistant
Copy link

CLAassistant commented Nov 22, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@amanepam2023 amanepam2023 changed the title Fix 409495] filters section users Filter Fix [409495] filters section users Filter Nov 22, 2023
Copy link

github-actions bot commented Nov 22, 2023

Jest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit a9c0f27. ± Comparison against base commit f863b58.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 22, 2023

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit a9c0f27. ± Comparison against base commit f863b58.

♻️ This comment has been updated with latest results.

@amanepam2023 amanepam2023 changed the title Fix [409495] filters section users Filter C409495_Filters section: Users filter_Firebird (TaaS) Nov 22, 2023
@amanepam2023 amanepam2023 marked this pull request as ready for review November 23, 2023 06:14
@amanepam2023 amanepam2023 requested review from yauheniya-kryshtafovich and removed request for manowarqqq and tomleexx November 29, 2023 16:39
@manowarqqq
Copy link
Contributor

Please, add a screenshot from Jenkins run. Not local
Please, for fututre tests use rebase and amend to have 1 commit

@@ -0,0 +1,43 @@
import permissions from '../../../support/dictionary/permissions';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, move file to bulk-edit/logs
bulk-edit-filter-section-user-filter-page.cy.js

describe('bulk-edit', () => {
before('create test users', () => {
cy.createTempUser([
permissions.bulkEditLogsView.gui,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Permissions

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what need to be done here? I gave required permissions as per testcase.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just code convension Premissions

users.deleteViaApi(user.userId);
});

it('Filters section: Users filter', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add TC id, tags and names for dev teams. See other tests

BulkEditSearchPane.checkHoldingsCheckbox();
BulkEditSearchPane.checkItemsCheckbox();
BulkEditSearchPane.checkUsersCheckbox();
BulkEditSearchPane.verifyLogsTableHeaders();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed some expected results from Step2
Missed lots of expected results. Please add it

@@ -82,6 +87,14 @@ export default {
cy.expect(searchButton.has({ disabled: isDisabled }));
},

xAppearsNextToUser() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verifyUserAccordionHasXIcon() {
cy.expect(Section({ id: 'userId'}).find(Button({icon: 'times-circle-solid' })).exists())
}

cy.expect(xIconButtonUser.exists());
},

clickOnXAppearsNextToUser() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clearUserAccordion() {
cy.expect(Section({ id: 'userId'}).find(Button({icon: 'times-circle-solid' })).click())
}

cy.do(logsUsersAccordion.find(buttonChooseUser).click());
},

searchUser(name) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verifyUserIsNotInUserList() {
cy.do([Selection(id...).open(), SelectionList().find(SelectionOption(name)).absent()]);
}

cy.contains('List is empty').should('be.visible');
cy.contains('No matching option').should('be.visible');
},
searchAndSelectUser(name) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cy.do([Selection(id...).open(), SelectionList().select(user)]);

clickChooseUserUnderUserAccordion is redundant

BulkEditSearchPane.verifyLogsTableHeaders();
BulkEditSearchPane.clickUserAccordion();
BulkEditSearchPane.clickChooseUserUnderUserAccordion();
BulkEditSearchPane.searchAndSelectUser('Test_All');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the user 'Test_All'?
I suppose need to create User via API in before section and delete it in after section
See another tests
Users.createViaApi...

cy.login(user.username, user.password, {
path: TopMenu.bulkEditPath,
waiter: BulkEditSearchPane.waitLoading,
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed precondtion from TC
The FOLIO contains completed Bulk Edit jobs, jobs were run by different Users
Ask AQA from Firebird team how to do this (Guliyashnar Nayimova (nayimovag))

@manowarqqq manowarqqq changed the title C409495_Filters section: Users filter_Firebird (TaaS) C409495_Filters section: Users filter_Firebird (Firebird) Nov 30, 2023
@Scorpibear Scorpibear changed the title C409495_Filters section: Users filter_Firebird (Firebird) C409495: Filters section: Users filter (Firebird) (TaaS) Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants