Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cn-browse): Implement Database Structure and Logic for Managing Call Numbers #702

Merged
merged 3 commits into from
Dec 2, 2024
Merged

feat(cn-browse): Implement Database Structure and Logic for Managing Call Numbers #702

merged 3 commits into from
Dec 2, 2024

Conversation

psmagin
Copy link
Contributor

@psmagin psmagin commented Nov 28, 2024 •
edited
Loading

Purpose

Implement Database Structure and Logic for Managing Call Numbers

Approach

  • add new database tables
  • create logic for extracting and saving call-numbers and their relations
  • create a new feature flag for call-number browse.

Changes Checklist

  • API Changes: Document any API paths, methods, request or response bodies changed, added, or removed.
  • Database Schema Changes: Indicate any database schema changes and their impact. Confirm that migration scripts were created.
  • Interface Version Changes: Indicate any changes to interface versions.
  • Interface Dependencies: Document added or removed dependencies.
  • Permissions: Document any changes to permissions.
  • Logging: Confirm that logging is appropriately handled.
  • Unit Testing: Confirm that changed classes were covered by unit tests.
  • Integration Testing: Confirm that changed logic was covered by integration tests.
  • Manual Testing: Confirm that changes were tested on local or dev environment.
  • NEWS: Confirm that the NEWS file is updated with relevant information about the changes made in this pull request.

Related Issues

https://folio-org.atlassian.net/browse/MSEARCH-862

@psmagin psmagin changed the base branch from master to feature/call-number-browse-v2 November 28, 2024 14:16
@psmagin psmagin marked this pull request as ready for review November 28, 2024 14:27
@psmagin psmagin requested a review from a team as a code owner November 28, 2024 14:27
@psmagin psmagin requested review from viacheslavkol, mukhiddin-yusuf and SvitlanaKovalova1 and removed request for a team November 28, 2024 14:27
@psmagin psmagin self-assigned this Nov 28, 2024
@psmagin psmagin changed the title fix(cn-browse): Implement Database Structure and Logic for Managing Call Numbers feat(cn-browse): Implement Database Structure and Logic for Managing Call Numbers Nov 29, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@psmagin psmagin merged commit 5cadf05 into feature/call-number-browse-v2 Dec 2, 2024
8 checks passed
@psmagin psmagin deleted the MSEARCH-862 branch December 2, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mukhiddin-yusuf mukhiddin-yusuf mukhiddin-yusuf approved these changes

@viacheslavkol viacheslavkol viacheslavkol approved these changes

@SvitlanaKovalova1 SvitlanaKovalova1 Awaiting requested review from SvitlanaKovalova1 SvitlanaKovalova1 is a code owner automatically assigned from folio-org/spitfire-backend

Assignees

@psmagin psmagin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@psmagin @viacheslavkol @mukhiddin-yusuf