Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor the handling of idle state #227

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Conversation

pythonbrad
Copy link
Member

Related issue

Problem

We want the idle state be handled at the main thread. And the rdev::listen thread should just forward the key events. Like that we can easily use the idle state without share memory.

We want the idle state be handled at the main thread.
And the rdev::listen thread should just forward the key events.
Like that we can easily use the idle state without share memory.
@pythonbrad pythonbrad self-assigned this Apr 22, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8787969133

Details

  • 27 of 27 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.07%) to 98.727%

Files with Coverage Reduction New Missed Lines %
service/src/convert.rs 1 68.75%
Totals Coverage Status
Change from base Build 8787883702: -0.07%
Covered Lines: 1473
Relevant Lines: 1492

💛 - Coveralls

@pythonbrad pythonbrad merged commit da22291 into main Apr 22, 2024
6 checks passed
@pythonbrad pythonbrad deleted the chore_listener branch April 22, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

all keyboard event should be handle to the main thread
2 participants