Improving parenthesizing of binary expressions #1258
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The serialization of binary expressions currently suffers from two problems:
serializer_context<>::use_parentheses=true
flag. As soon as it is changed, as in CTEs, the serialization goes wrong.check()
,default()
).select(&Employee::salary >= select(avg(&Employee::salary)))
works.This leads to a simplified approach, as the serializer is independent of the context.
In addition, fewer characters are serialized with simple binary expressions, which also improves the readability of statements when they are examined.
Also in this PR:
select(c(5) > 3 == true)
are possible instead ofselect(c(5) > 3 == c(true))