Permanent memory space for a user-defined function #1248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fnc12
reviewed
Nov 16, 2023
This approach is not cumbersome when it comes to raw storage and the possible memory requirements of the user-defined function classes, and therefore sticks to regular "new"/"delete" expressions.
fnc12
approved these changes
Nov 18, 2023
fnc12
approved these changes
Nov 19, 2023
trueqbit
commented
Nov 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of recreating a user-defined function on the "free store" each time it is used for calculations, the memory space is now allocated once together with the "proxy" object registered with SQLite, so that the user-defined function only needs to be reconstructed.
Additional features in this PR:
Additional improvements in this PR:
call()function bystd::apply().