Node hours report #1053
Open
Node hours report #1053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add core-hours and node-hours to the logfile for every step
fixed how things are calculated in Vlasiator
ursg
approved these changes
Nov 5, 2024
Comment on lines
+428
to
+429
| const double GiB = pow(2,30); | ||
| const double TiB = pow(2,40); |
There was a problem hiding this comment.
These are never actually used below, as far as I can see?
There was a problem hiding this comment.
Right these came from where we copied the rest of the code and can go indeed.
| MPI_Comm_rank(interComm, &interRank); | ||
| MPI_Comm_size(interComm, &nNodes); | ||
|
|
||
| MPI_Comm_free(&interComm); |
There was a problem hiding this comment.
Good catch. Instead in between we were freeing interComm twice. 😬
ykempf
requested changes
Nov 5, 2024
vlasiator.cpp
Outdated
Comment on lines
912
to
914
| logFile << "(TIME) total node-hours " << nNodes*(currentTime - startTime)/3600 << " h" << endl; | ||
| #if _OPENMP | ||
| logFile << "(TIME) total core-hours " << omp_get_max_threads()*mpiProcs*(currentTime - startTime)/3600 << " h" << endl; |
There was a problem hiding this comment.
Let's change the wording to "current" or "cumulated" here, "total" at the end (our own copy-paste problem here :)).
vlasiator.cpp
Outdated
Comment on lines
1394
to
1396
| logFile << "\t (TIME) total node-hours " << nNodes*(after - startTime)/3600 << " h" << endl; | ||
| #if _OPENMP | ||
| logFile << "\t (TIME) total core-hours " << omp_get_max_threads()*mpiProcs*(after - startTime)/3600 << " h" << endl; |
There was a problem hiding this comment.
And I would suggest to reorder and have all of these (above and here) say sth like "(TIME) total x.y node-hours" instead of "node-hours x.y h"
Reorder the sentence and add MPI_Comm_free for nodeComm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add core-hours and node-hours to the logfile for every step
Fixed with Yann