Activate report grid memory consumption #1020
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have this function, why not use it?
|
Suggestion from Markus: implement a similar memory report functionality for fsgrid. Not today. |
|
Example output: So let's discuss if we want more info (value and rank of local vs. remote cells' min and max capacity?), and in what format/ordering. And also, this should list explicitly that we're talking of the spatial cells here, especially if/when we extend this to also report fsgrid memory usage. |
…w places in grid.cpp.
| @@ -753,13 +753,26 @@ void shrink_to_fit_grid_data(dccrg::Dccrg<SpatialCell,dccrg::Cartesian_Geometry> | |||
| } | |||
| } | |||
|
|
|||
| std::vector<CellID> get_all_remote_cells_on_process_boundary(dccrg::Dccrg<SpatialCell,dccrg::Cartesian_Geometry>& mpiGrid) { | |||
There was a problem hiding this comment.
as per DCCRG neighborhoods, this can go away
| @@ -816,7 +831,7 @@ void report_grid_memory_consumption(dccrg::Dccrg<SpatialCell,dccrg::Cartesian_Ge | |||
| */ | |||
| void deallocateRemoteCellBlocks(dccrg::Dccrg<SpatialCell,dccrg::Cartesian_Geometry>& mpiGrid) { | |||
| const std::vector<uint64_t> incoming_cells | |||
| = mpiGrid.get_remote_cells_on_process_boundary(VLASOV_SOLVER_NEIGHBORHOOD_ID); | |||
There was a problem hiding this comment.
and by passing no neighborhood to mpiGrid.get_remote_cells_on_process_boundary() it should return for the base neighborhood i.e. all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just for laughs? How long has this not been used? Not like I just spent a number of weeks looking into memory consumption...........