Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated instructions for launching moveit_rviz.launch #11

Closed
ljden opened this issue Jul 10, 2021 · 2 comments
Closed

Outdated instructions for launching moveit_rviz.launch #11

ljden opened this issue Jul 10, 2021 · 2 comments
Assignees

Comments

@ljden
Copy link

ljden commented Jul 10, 2021

The readme still says to run the moveit_rviz.launch with config:=true, however the interface has changed with the recent updates:

<arg name="rviz_config" default="" />
<arg if="$(eval rviz_config=='')" name="command_args" value="" />
<arg unless="$(eval rviz_config=='')" name="command_args" value="-d $(arg rviz_config)" />

From UniversalRobots/Universal_Robots_ROS_Driver#403 (comment) it seems like config:=true should be config:=$(rospack find ur5_moveit_config)/launch/moveit.rviz

I will open a separate issue regarding moveit.rviz defaulting to the endeffector group rather than manipulator

@fmauch
Copy link
Owner

fmauch commented Jul 22, 2021

The main README file has indeed not been touched, yet and should get some overhaul.

@fmauch
Copy link
Owner

fmauch commented Jul 21, 2022

This is covered upstream and should be covered by ros-industrial#538

@fmauch fmauch closed this as completed Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants