Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] allow python interface to get the default inputs from launch plan #2949

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KyleShao1016
Copy link

@KyleShao1016 KyleShao1016 commented Nov 22, 2024

Tracking issue

Closes flyteorg/flyte#6030

Why are the changes needed?

Initially, the launch plan only retrieved the interface from the workflow. However, this approach could not get the default inputs of the launch plan. Adding a new argument, python_interface, to the launch plan resolves the issue where inputs could not be processed directly from the launch plan.

What changes were proposed in this pull request?

  1. adding a new parameter python_interface
  2. return this parameter when launch plan is instantiate

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Copy link

welcome bot commented Nov 22, 2024

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

Copy link
Contributor

@Mecoli1219 Mecoli1219 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KyleShao1016 Three things to update:

  1. Sign off your commit
  2. It seems like some of your updates break some unit tests. You can either update the broken unit tests or your code to make sure the original unit tests are passed. You can check it with make test command.
  3. Create some unit tests related to the bug you fixed. They could be added somewhere like here: https://github.com/flyteorg/flytekit/blob/master/tests/flytekit/unit/core/test_launch_plan.py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] pyflyte run launch plan with default inputs cannot be run successfully
2 participants