Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade CI to use latest protobuf version #2946

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

eapolinario
Copy link
Collaborator

Tracking issue

Closes flyteorg/flyte#5448

Why are the changes needed?

The bugs caused by the latest major protobuf version were resolved. Time to use protobuf 5 in flytekit CI.

What changes were proposed in this pull request?

Remove pinned versions of protobuf in CI and in the dev environment setup.

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

…quirements.txt` file

Signed-off-by: Eduardo Apolinario <[email protected]>
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.09%. Comparing base (2e40e76) to head (9491b42).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2946      +/-   ##
==========================================
- Coverage   78.59%   76.09%   -2.51%     
==========================================
  Files         199      200       +1     
  Lines       20886    20835      -51     
  Branches     2688     2688              
==========================================
- Hits        16416    15855     -561     
- Misses       3764     4261     +497     
- Partials      706      719      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Housekeeping] Add support for protobuf version 5 in flytekit
1 participant