Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple Ray Resources: Construct ray k8spods from Resources #2943

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Decouple Ray Resources: Construct ray k8spods from Resources #2943

wants to merge 14 commits into from

Commits on Nov 20, 2024

  1. expose requests & limits instead of k8spod 

    Signed-off-by: Jan Fiedler <[email protected]>
    @fiedlerNr9
    fiedlerNr9 committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    5f551d9 View commit details
    Browse the repository at this point in the history

  2. put construct_k8s_pod_spec_from_resources into core/resources.py 

    Signed-off-by: Jan Fiedler <[email protected]>
    @fiedlerNr9
    fiedlerNr9 committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    efd58f0 View commit details
    Browse the repository at this point in the history

  3. adjust ray tests 

    Signed-off-by: Jan Fiedler <[email protected]>
    @fiedlerNr9
    fiedlerNr9 committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    7c74bb7 View commit details
    Browse the repository at this point in the history

  4. ruff check fix 

    Signed-off-by: Jan Fiedler <[email protected]>
    @fiedlerNr9
    fiedlerNr9 committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    3d84516 View commit details
    Browse the repository at this point in the history

  5. ruff format 

    Signed-off-by: Jan Fiedler <[email protected]>
    @fiedlerNr9
    fiedlerNr9 committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    d192625 View commit details
    Browse the repository at this point in the history

  6. remove demo files from PR 

    Signed-off-by: Jan Fiedler <[email protected]>
    @fiedlerNr9
    fiedlerNr9 committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    94b7797 View commit details
    Browse the repository at this point in the history

  7. remove kubernetes from ray plugin dependencies 

    Signed-off-by: Jan Fiedler <[email protected]>
    @fiedlerNr9
    fiedlerNr9 committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    0b72707 View commit details
    Browse the repository at this point in the history

  8. Update structured_dataset.py 

    Signed-off-by: Jan Fiedler <[email protected]>
    @fiedlerNr9
    fiedlerNr9 committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    da7d6ae View commit details
    Browse the repository at this point in the history

  9. add tests for construct_k8s_pod_spec_from_resources 

    Signed-off-by: Jan Fiedler <[email protected]>
    @fiedlerNr9
    fiedlerNr9 committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    17d9d66 View commit details
    Browse the repository at this point in the history

  10. add kubernetes to pyproject.toml 

    Signed-off-by: Jan Fiedler <[email protected]>
    @fiedlerNr9
    fiedlerNr9 committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    72a3339 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2024

  1. add underscore prefix to _construct_k8s_pods_resources 

    Signed-off-by: Jan Fiedler <[email protected]>
    @fiedlerNr9
    fiedlerNr9 committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    f3bd304 View commit details
    Browse the repository at this point in the history

  2. remove parantheses from_flyte_idl 

    Signed-off-by: Jan Fiedler <[email protected]>
    @fiedlerNr9
    fiedlerNr9 committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    7692641 View commit details
    Browse the repository at this point in the history

  3. expose k8s_gpu_resource_key 

    Signed-off-by: Jan Fiedler <[email protected]>
    @fiedlerNr9
    fiedlerNr9 committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    0edfb68 View commit details
    Browse the repository at this point in the history

  4. remove parantheses 

    Signed-off-by: Jan Fiedler <[email protected]>
    @fiedlerNr9
    fiedlerNr9 committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    7676af6 View commit details
    Browse the repository at this point in the history