fix: fix JSONParamType to handle serialization of custom objects #2931
+14
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalaoqi
force-pushed
the
5985-bug-with-customObject-in-dict-and-list
branch
from
a155053
to
36f98ed
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2931 +/- ##
===========================================
- Coverage 76.33% 46.75% -29.59%
===========================================
Files 199 199
Lines 20840 20789 -51
Branches 2681 2684 +3
===========================================
- Hits 15908 9719 -6189
- Misses 4214 10594 +6380
+ Partials 718 476 -242 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Tsung-Han Ho (dalaoqi) <[email protected]>
Signed-off-by: Tsung-Han Ho (dalaoqi) <[email protected]>
…intainability Signed-off-by: Tsung-Han Ho (dalaoqi) <[email protected]>
- Added a fallback check for `lv.scalar.union.value.collection.literals` in case `lv.collection` is None. - Prevents potential errors when `lv.collection` is not properly initialized. Signed-off-by: Tsung-Han Ho (dalaoqi) <[email protected]>
- Added validation to check for duplicate input names in the function's input interface. - Raised a ValueError if duplicate input names are detected to prevent issues during argument assignment. - Simplified the conversion of args to kwargs by removing the redundant multiple values check. Signed-off-by: Tsung-Han Ho (dalaoqi) <[email protected]>
dalaoqi
force-pushed
the
5985-bug-with-customObject-in-dict-and-list
branch
from
2ad9c6c
to
1ce0704
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Closes flyteorg/flyte#5985
Why are the changes needed?
The issue arises when trying to serialize lists or dictionaries that contain custom objects, as non-serializable custom objects cause a TypeError by default. This prevents successful serialization of data structures with instances of user-defined classes, necessitating a solution to convert these objects into a JSON-compatible format.
What changes were proposed in this pull request?
This pull request fixes JSON serialization issues for lists and dictionaries containing custom objects by adding support to convert non-serializable objects to JSON-compatible dictionaries.
Added default Parameter to json.dumps: Utilized
default=lambda o: o.dictin json.dumps calls to convert non-serializable custom objects into a JSON-compatible dictionary format.How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link