Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add on failure parameter to imperative workflow #2908

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

400Ping
Copy link
Contributor

@400Ping 400Ping commented Nov 6, 2024

Tracking issue

Related to flyteorg/flyte#5913

Why are the changes needed?

As the issue stated, this function is in the base class and I don't see why not to expose it to imperative workflows.

What changes were proposed in this pull request?

I add a on_failure parameter in the ImperativeWorkflow class, you can see it in the commit

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

flyteorg/flyte#5913

Docs link

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.44%. Comparing base (3b7cb3c) to head (8eecab4).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2908      +/-   ##
==========================================
+ Coverage   76.49%   79.44%   +2.94%     
==========================================
  Files         200      200              
  Lines       20901    20901              
  Branches     2689     2689              
==========================================
+ Hits        15989    16605     +616     
+ Misses       4195     3550     -645     
- Partials      717      746      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Member

@Future-Outlier Future-Outlier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. make lint to lint your code
  2. add tests to test this variable.

@400Ping 400Ping changed the title add on failure parameter to imperative workflow Add on failure parameter to imperative workflow Nov 15, 2024
@400Ping 400Ping requested a review from fg91 as a code owner November 22, 2024 13:21
@400Ping 400Ping closed this Nov 22, 2024
@400Ping 400Ping deleted the #5913 branch November 22, 2024 14:33
@400Ping 400Ping restored the #5913 branch November 22, 2024 14:34
@400Ping 400Ping reopened this Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

2 participants