Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add to_string method to literal #2906

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add to_string method to literal #2906

wants to merge 6 commits into from
+103 −6

Conversation

pingsutw
Copy link
Member

@pingsutw pingsutw commented Nov 5, 2024 •
edited
Loading

Tracking issue

NA

Why are the changes needed?

It's hard to read Literal.__str__, especially when you have a nested list or dict.

What changes were proposed in this pull request?

Add to_string to Literal to customize the representational string

How was this patch tested?

int_literal = Literal(scalar=Scalar(primitive=Primitive(integer=1)))
print(int_literal)
large_dict = Literal(map=LiteralMap({str(i): Literal(scalar=Scalar(primitive=Primitive(integer=i))) for i in range(100)}))
print(large_dict)
union_literal = Literal(scalar=Scalar(union=Union(value=large_dict, stored_type=LiteralType(SimpleType.INTEGER))))
print(union_literal)

Before:
Screenshot 2024-11-05 at 3 39 10 PM

After:
Screenshot 2024-11-05 at 3 38 35 PM

@pingsutw
wip
d393bb3 
Signed-off-by: Kevin Su <[email protected]>
@pingsutw
update test
684ac9d 
Signed-off-by: Kevin Su <[email protected]>
@pingsutw
update test
522716d 
Signed-off-by: Kevin Su <[email protected]>
pingsutw
pingsutw commented Nov 5, 2024
View reviewed changes
flytekit/core/type_engine.py
@@ -1605,7 +1605,7 @@ async def async_to_python_value( # type: ignore
except AttributeError:
raise TypeTransformerFailedError(
(
f"The expected python type is '{expected_python_type}' but the received Flyte literal value "
f"The expected python type is '{expected_python_type}' but the received {lv} "
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-11-05 at 3 31 10 PM

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @wild-endeavor

@pingsutw
lint
cab9d3d 
Signed-off-by: Kevin Su <[email protected]>
@pingsutw
merged master
f204e65 
Signed-off-by: Kevin Su <[email protected]>
@pingsutw
fix test
be80ffd 
Signed-off-by: Kevin Su <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wild-endeavor wild-endeavor Awaiting requested review from wild-endeavor wild-endeavor is a code owner

@kumare3 kumare3 Awaiting requested review from kumare3 kumare3 is a code owner

@eapolinario eapolinario Awaiting requested review from eapolinario eapolinario is a code owner

@cosmicBboy cosmicBboy Awaiting requested review from cosmicBboy cosmicBboy is a code owner

@samhita-alla samhita-alla Awaiting requested review from samhita-alla samhita-alla is a code owner

@thomasjpfan thomasjpfan Awaiting requested review from thomasjpfan thomasjpfan is a code owner

@Future-Outlier Future-Outlier Awaiting requested review from Future-Outlier Future-Outlier is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pingsutw