-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scoreboard Creation #79
base: master
Are you sure you want to change the base?
Conversation
(feat) Comments to understand the situation better
(feat) Added explanation in README.md
I love you |
I love you too dawson |
Is this the start of our relationship? |
Yes😍 |
yea gl getting anyone to merge this within 2024 💀 |
🫠😭 |
I've found a small error while testing today,if anyone looks at this and wants to merge, please wait until my next message as I'm fixing this issue tomorrow |
Done, thank you. |
@SamuSonoIo Please ping once ready to be merged again |
Fixed README.md Reworked the code a bit.
You're still misunderstanding 5. I'm talking about adding another Objective in another DisplaySlot, such as BELOW_NAME. This is bound to the org.bukkit.Scoreboard, no? If someone wants to have for example, an Objective for player health display BELOW_NAME, currently they would have to choose between that and a TwilightScoreboard SIDEBAR. Please correct me if I'm wrong, but that's how I understand it currently. |
Also @SamuSonoIo, have you tested the example code from the README where it references I'm not sure if I'm being stupid but I can't see how these scoreboards are per-player. If I join then the scoreboard would say my name, then if you join after it would say your name for both of us I think. |
Oh, I understand now. |
@joshbker |
Alright, yes I think as a library we really need to support those kind of things.
You don't create a new scoreboard instance per player in the README: |
Oh my bad then, i made an error in the readme. |
Will finish to fix everything tomorrow probably, |
Added removeTo method
I can't think of anything more at the moment, think if you/we address all of the thinggs we've spoken about so far then we'll be in a great position with this. |
src/main/kotlin/gg/flyte/twilight/scoreboard/TwilightScoreboard.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/gg/flyte/twilight/scoreboard/TwilightScoreboard.kt
Outdated
Show resolved
Hide resolved
Hi @joshbker |
Hey! I basically remade everything, now the entire scoreboard system is in one class, and it only has the methods that are actually needed, no unnecessary ones, so everything is nice and clean. That's about it! |
Forgot to add the player to the Map in the ReadME
Hello! 👋
I noticed that many people, including myself, struggle with creating scoreboards for Minecraft plugins. So, I decided to add this feature to Twilight to make it easier for everyone!
The process of creating a scoreboard is fully explained in the README.md file, and I've made sure that everything is easy to use and well-explained (at least, I believe so).
With my feature, you can create either a Static or a Dynamic scoreboard, or even combine the two. For example, you can create a static scoreboard and then update only specific lines (though, I personally don't see much use for this, but it's possible!).
If there is something in the code that maybe isn't clean, or need a refactoring, let me know and i'll fix it up as soon as i can.
Thank you!