vk: Add VK_EXT_provoking_vertex optimization
#1681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dreamcast uses the last vertex as the provoking vertex, while vulkan uses the first vertex. This requires an additional call to `setFirstProvokingVertex` to reorder the vertices for all incoming geometry. With `VK_EXT_provoking_vertex`, the pipeline can designate that the provoking vertex is to be the last vertex, which removes the need to re-order incoming geometry on the CPU.
Allows VMA to make assumptions such as using the `*KHR` or non-`KHR` versions of certain function names.
Despite the physical device possibly being 1.2 or 1.3, we only want up to 1.1. Otherwise we will be responsible for other API functions being resolved and loaded when passing to VMA.
Pretty much anything handling dreamcast-geometry should use this extension when available
|
Works fine in my limited tests, but I also don't know of any titles that are particularly sensitive to the order of the provoking vertex |
|
A good test is games using flat shading (most games use Gouraud shading). For example, the first battle in Evolution - The World of Sacred Device. |
|
master(556e2ea): flycast_5Td61dT0Ax.mp4This PR: flycast_Ev9IsdBl6J.mp4Seems to be interpreting the last vertex properly when using |
|
Looks good. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dreamcast uses the last vertex as the provoking vertex, while vulkan uses the first vertex.
This requires an additional call to
setFirstProvokingVertexto reorder the vertices for all incoming geometry.With
VK_EXT_provoking_vertex, the pipeline can designate that the provoking vertex is to be the last vertex, which removes the need to re-order incoming geometry on the CPU.