Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vk: Disable LOD clamping in samplers #1674

Merged
merged 2 commits into from
Oct 9, 2024
Merged

vk: Disable LOD clamping in samplers #1674

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b94a6e7
vk: Disable LOD clamping in samplers
Wunkolo Oct 9, 2024
51abd6a
Merge branch 'master' into vk-bestpractices-arm-lod-clamping
flyinghead Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/rend/vulkan/pipeline.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,7 +398,7 @@ class OSDPipeline
vk::SamplerCreateInfo(vk::SamplerCreateFlags(), vk::Filter::eLinear, vk::Filter::eLinear,
vk::SamplerMipmapMode::eLinear, vk::SamplerAddressMode::eClampToEdge, vk::SamplerAddressMode::eClampToEdge,
vk::SamplerAddressMode::eClampToEdge, 0.0f, false, 16.0f, false,
vk::CompareOp::eNever, 0.0f, 0.0f, vk::BorderColor::eFloatOpaqueBlack));
vk::CompareOp::eNever, 0.0f, vk::LodClampNone, vk::BorderColor::eFloatOpaqueBlack));
}
if (this->renderPass != renderPass)
{
Expand Down
4 changes: 2 additions & 2 deletions core/rend/vulkan/quad.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ void QuadPipeline::Init(ShaderManager *shaderManager, vk::RenderPass renderPass,
vk::SamplerAddressMode::eClampToEdge,
vk::SamplerAddressMode::eClampToEdge,
vk::SamplerAddressMode::eClampToEdge, 0.0f, false,
16.0f, false, vk::CompareOp::eNever, 0.0f, 0.0f,
16.0f, false, vk::CompareOp::eNever, 0.0f, vk::LodClampNone,
vk::BorderColor::eFloatOpaqueBlack));
}
if (!nearestSampler)
Expand All @@ -162,7 +162,7 @@ void QuadPipeline::Init(ShaderManager *shaderManager, vk::RenderPass renderPass,
vk::SamplerAddressMode::eClampToEdge,
vk::SamplerAddressMode::eClampToEdge,
vk::SamplerAddressMode::eClampToEdge, 0.0f, false,
16.0f, false, vk::CompareOp::eNever, 0.0f, 0.0f,
16.0f, false, vk::CompareOp::eNever, 0.0f, vk::LodClampNone,
vk::BorderColor::eFloatOpaqueBlack));
}
if (this->renderPass != renderPass)
Expand Down
4 changes: 2 additions & 2 deletions core/rend/vulkan/vulkan_driver.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ class VulkanDriver final : public ImGuiDriver
vk::SamplerAddressMode::eClampToBorder,
vk::SamplerAddressMode::eClampToBorder,
vk::SamplerAddressMode::eClampToBorder, 0.0f, false,
0.f, false, vk::CompareOp::eNever, 0.0f, VK_LOD_CLAMP_NONE,
0.f, false, vk::CompareOp::eNever, 0.0f, vk::LodClampNone,
vk::BorderColor::eFloatTransparentBlack));
}
sampler = (VkSampler)*pointSampler;
Expand All @@ -116,7 +116,7 @@ class VulkanDriver final : public ImGuiDriver
vk::SamplerAddressMode::eClampToBorder,
vk::SamplerAddressMode::eClampToBorder,
vk::SamplerAddressMode::eClampToBorder, 0.0f, false,
0.f, false, vk::CompareOp::eNever, 0.0f, VK_LOD_CLAMP_NONE,
0.f, false, vk::CompareOp::eNever, 0.0f, vk::LodClampNone,
vk::BorderColor::eFloatTransparentBlack));
}
sampler = (VkSampler)*linearSampler;
Expand Down
Loading