vk: Use matching u/v/w sampler address-mode when possible #1673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses the `BestPractices-Arm-vkCreateSampler-different-wrapping-modes` message from ARM: https://github.com/KhronosGroup/Vulkan-ValidationLayers/blob/65b79bac615ec1c47ab61a02d55a3bba871b56b9/layers/best_practices/bp_descriptor.cpp#L95-L100 The `W`-axis for these samplers is always unused, it's never the case that these samplers are going to be used for 3D textures. ARM suggests trying to keep all of the wrapping-modes the same if possible for performance. `wRepeat` will be set to the same value as `vRepeat` to try and encourage all three wrapping-modes to be the same.
Wunkolo
force-pushed
the
vk-bestpractices-arm-wrapping-modes
branch
from
26f739d to
ab810d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the
BestPractices-Arm-vkCreateSampler-different-wrapping-modesmessage from ARM: https://github.com/KhronosGroup/Vulkan-ValidationLayers/blob/65b79bac615ec1c47ab61a02d55a3bba871b56b9/layers/best_practices/bp_descriptor.cpp#L95-L100The
W-axis for these samplers is always unused, it's never the case that these samplers are going to be used for 3D textures. ARM suggests trying to keep all of the wrapping-modes the same if possible for performance.wRepeatwill be set to the same value asvRepeatto try and encourage all three wrapping-modes to be the same.