vk: Refactor physical device selection #1671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than electing the first physical device it finds, and falling back on the first-listed GPU: a series of stable-partitions are done so that the "least compromising" GPU is selected based on a series of criteria. It will now maximally try to find a GPU that(in order of priority): * Is a discrete GPU * Supports `R5G5B5`/`R5G6B5A1`/`R4G4B4A4` * Supports `fragmentStoresAndAtomics` In the case that a system has two dGPUs and one of them supports optimal-formats, the optimal-format one is selected In the case that a system has an iGPU and the dGPU and they both support optimal formats, the dGPU is selected. In the case that a system has an iGPU and the dGPU and the dGPU doesn't support optimal formats, the dGPU is still selected.
|
Thank you for your contribution. |
* Is a discrete GPU * Supports fragmentStoresAndAtomics * Supports R5G5B5/R5G6B5A1/R4G4B4A4
Wunkolo
force-pushed
the
vk-physical-device-selection
branch
from
e061365 to
f637b51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than electing the first physical device it finds, and falling back on the first-listed GPU: a series of stable-partitions are done so that the "least compromising" GPU is selected based on a series of criteria.
It will now maximally try to find a GPU that(in order of priority):
R5G5B5/R5G6B5A1/R4G4B4A4fragmentStoresAndAtomicsIn the case that a system has two dGPUs and one of them supports optimal-formats, the optimal-format one is selected
In the case that a system has an iGPU and the dGPU and they both support optimal formats, the dGPU is selected.
In the case that a system has an iGPU and the dGPU and the dGPU doesn't support optimal formats, the dGPU is still selected.