Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slider to change crosshair size and a core option for the Libretro core #1304

Merged
merged 2 commits into from
Nov 18, 2023

Conversation

bslenul
Copy link
Contributor

@bslenul bslenul commented Nov 16, 2023

For standalone I made a slider going from 10 to 100 with 40 being the default, the slider will be greyed out until at least 1 "Crosshair" box is checked:

xhair_size.mp4

For Libretro I made a scaling option going from 50% to 300%:

lr-xhair_size.mp4

For standalone code I wasn't sure how to handle

constexpr int XHAIR_WIDTH = 40;
constexpr int XHAIR_HEIGHT = 40;

So I simply replaced every instances of these with config::CrosshairSize, I hope this is fine... If this is not OK with you and you prefer to handle the standalone stuff yourself please tell me, I'll update the PR to keep the Libretro commit only ;)

@flyinghead flyinghead merged commit 78a874d into flyinghead:master Nov 18, 2023
13 checks passed
@bslenul bslenul deleted the xhair-size branch November 18, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants