Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: create folder hierarchy only for Xcode or Visual Studio generators #1293

Merged
merged 1 commit into from
Nov 18, 2023

Conversation

scribam
Copy link
Collaborator

@scribam scribam commented Nov 11, 2023

When using CLion + WSL2, the file + source_group directives impact negatively the performance of the cmake configuration step.

@vkedwardli Can you please review this since you added this part?

@scribam scribam requested a review from vkedwardli November 11, 2023 14:25
@vkedwardli
Copy link
Collaborator

vkedwardli commented Nov 16, 2023

This is required for Visual Studio project also, could use ^Xcode.*|^Visual Studio.* ?

image

@scribam scribam changed the title cmake: create folder hierarchy only for Xcode project cmake: create folder hierarchy only for Xcode or Visual Studio generators Nov 17, 2023
@scribam
Copy link
Collaborator Author

scribam commented Nov 17, 2023

Indeed. PR updated to add Visual Studio projects

@flyinghead flyinghead merged commit 3303ecb into flyinghead:dev Nov 18, 2023
13 checks passed
@scribam scribam deleted the xcode-folders branch November 18, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants