-
-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BIOS boot animation not playing when no disk is inserted #587
Comments
Thank You For Responding Quickly. Even if you eject the disk at the bios menu, the bios still believes that the tray is open causing the bouncing dreamcast logo to not play. when the tray is closed on the real hardware even with no disc inserted, it still does the bouncing logo before sending you to the bios main menu. e.g.: https://www.youtube.com/watch?v=5lsrKZxiYVg at 0:35 |
Github hash: e592650 I tested it as follows and it seems to work fine.
...
void PowerOnNoDisk();
...
...
void PowerOnNoDisk()
{
NullDriveDiscType = NoDisk;
gd_setdisc();
}
...
static bool doDiscSwap(const std::string& path)
{
if (path.empty())
{
TermDrive();
//NullDriveDiscType = NoDisk;
return true;
}
...
...
#include "imgread/common.h"
...
void UpdateInputState()
{
FC_PROFILE_SCOPE;
input_sdl_handle();
if (GetAsyncKeyState(VK_F10))
PowerOnNoDisk();
}
|
Thanks to kihato for the prototype code. Issue #587
Should be fixed in the latest Thank you for the prototype code! |
Thanks to kihato for the prototype code. Issue #587
Is your feature request related to a problem? Please describe.
On the real hardware when opening the disk tray or closing the disk tray it would do different behaviour depending on if you where in the bios or in a game.
Describe the solution you'd like:
The solution is instead of having just eject disk, you could add Open Tray then eject disk, Close Tray and Vice Versa, if the user wants it to be simplified they can disable it within settings.
Describe alternatives you've considered:
I have tried other emulators over the years, such as the libetro forks and DEmul but both of them have their own problems including, retroarch no longer supporting the tray functionality anymore, and DEmul no longer being updated and being closed source are major issues for me personally.
Additional Context:
This enhancement may fix issue: #189
The text was updated successfully, but these errors were encountered: