Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homebrew game RevolveR doesn't work with lightgun #1369

Closed
Widge-5 opened this issue Jan 17, 2024 · 6 comments · Fixed by #1379
Closed

Homebrew game RevolveR doesn't work with lightgun #1369

Widge-5 opened this issue Jan 17, 2024 · 6 comments · Fixed by #1379
Labels
bug Something isn't working input Related to input controllers and devices

Comments

@Widge-5
Copy link

Widge-5 commented Jan 17, 2024

Platform / OS / Hardware:
Raspberry Pi 5, Bookworm 64 Bit, RetroPie/Retroarch , lr-flycast-dev
also Raspberry Pi 4, Buster 32 Bit, RetroPie/Retroarch , lr-flycast-dev (older version)

Github hash:
195f401 (and 5ae7ac3 for comparison)

Description of the Issue

The homebrew lightgun game, "RevolveR" locks up controls when the lightgun is fired in lr-flycast-dev only. this issue is not present in libretro flycast (called lr-flycast in RetroPie-Setup).
If the game is started with the Lightgun device type, you can fire only one shot, and it always hits the center of the screen, After that no further control inputs will do anything, though the game will continue playing.
If the game is started with a Controller Device Type, the player can play normally by guiding a crosshair, with a standard controller but if the device type is switched mid-game to a Lightgun, the problem manifests, you only get one shot then controls lock up. Attempting to change the device type back to Controller has no effect.

Another HomeBrew game, Bloop, has a similar issue, whereby you can't even Start a game using the gun (it stays on the title screen). You can start a game with a controller and play that way, and changing the device to Lightgun gives the lightgun control of the crosshair and shots are heard when the trigger is pulled, but no shots appear to land on screen. This problem is also not present with libretro lr-flycast

Debugging Steps Tested

  • I compiled the latest commit of lr-flycast dev on a Pi5 and tried that. The issue occurs.
  • I tried RevolveR on a recently compiled commit of libretro lr-flycast on a Pi5- the issue does not occur.
  • I tried Revolver on an old commit from July 2022 ( 5ae7ac3 ) that happened to be on my Pi 4 and I found that the issue did occur.
    That commit was from July 2022, so the problem seems to have existed at least that long.
  • The game runs perfectly fine on my real dreamcast via gdemu with a dreamcast gun (albeit with an inherent accuracy offset baked-in).
  • I have tried changing various core options to no avail. libretro flycast is consistenly able to run the game correctly, but flycast-dev consistently fails.

It seems that libretro-flycast succeeds where flycast-dev does not in this case. It would appear to me that a change to flycast sometime since this repo and libretro's forked from each other may have broken compatibility for this game.

Thank you for your time.

@Widge-5 Widge-5 added the bug Something isn't working label Jan 17, 2024
@flyinghead flyinghead added the input Related to input controllers and devices label Jan 17, 2024
@flyinghead
Copy link
Owner

what is the source of lr-flycast? is it the old core repo: https://github.com/libretro/flycast?

@Widge-5
Copy link
Author

Widge-5 commented Jan 17, 2024

Yes, that's the one. The last commit there was April 2022.

@Widge-5
Copy link
Author

Widge-5 commented Jan 18, 2024

For clarity, lr-flycast-dev is how Retropie-Setup refers to this repo of flycast (master branch).

@flyinghead
Copy link
Owner

I was able to reproduce the issue and figure out the problem.

flyinghead added a commit that referenced this issue Jan 28, 2024
Raise a maple interrupt at the next vblank when the host occupies the
maple bus to read the lightgun position. Fixes RevolveR single shot
issue since the game is waiting for the interrupt.
Issue #1369
@flyinghead
Copy link
Owner

Should be fixed in the latest dev build

@Widge-5
Copy link
Author

Widge-5 commented Jan 28, 2024

Thanks @flyinghead . That commit does seem to have fixed the problem. The game plays as exactly expected now. 👍

@flyinghead flyinghead linked a pull request Feb 1, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working input Related to input controllers and devices
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants