Merge pull request allenh1#6 from tiiuae/DP-1508-galactic_porting

Warning fixes
fly4future · Dec 9, 2021 · cc550b5 · cc550b5
2 parents 403c488 + 976522a
commit cc550b5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/launch/rplidar.launch.py b/launch/rplidar.launch.py
@@ -6,9 +6,9 @@
 def generate_launch_description():
     return LaunchDescription([
         Node(
-            node_name='rplidar',
+            name='rplidar',
             package='rplidar_ros2',
-            node_executable='rplidar',
+            executable='rplidar',
             output='screen',
             parameters=[
                 path.join(get_package_share_directory('rplidar_ros2'), 'config',

diff --git a/src/client.cpp b/src/client.cpp
@@ -47,7 +47,7 @@ void scanCallback(const std::shared_ptr<sensor_msgs::msg::LaserScan> scan)
    const auto& logger = rclcpp::get_logger("RPlidar Client");
    const auto count = static_cast<size_t>(scan->scan_time / scan->time_increment);
 
-   RCLCPP_INFO(logger, "I heard a laser scan %s[%d]:", scan->header.frame_id.c_str(), count);
+   RCLCPP_INFO(logger, "I heard a laser scan %s[%ld]:", scan->header.frame_id.c_str(), count);
    RCLCPP_INFO(logger, "angle_range, %f, %f", radians_to_degrees(scan->angle_min), radians_to_degrees(scan->angle_max));
 
    for (size_t index = 0; index < count; ++index) {