Fix importing #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, it's more difficult to debug errors
We previously had a bug where, due to the fact that we weren't skipping DNS registration, `fly pg import` would create a machine that tried to import from itself, obviously failing. Although the DNS registration bug is [being fixed](https://github.com/superfly/fly-proxy/pull/1192), I still think that relying on skipping DNS registration is a little silly, when we can just guarantee we'll connect to the correct machine using 6PN wizardry. `flyctl` needs to specify a machine ID to connect to which, as of writing, is just any working machine in the app we want to import into.
billyb2
added a commit
to superfly/flyctl
that referenced
this pull request
Mar 25, 2024
Relies on fly-apps/postgres-importer#7, but basically, we just specify the machine ID of the machine to connect to when importing, rather than relying on `<appname>.internal` not giving us the ID of the ephemeral machine.
matttpt
approved these changes
Mar 25, 2024
billyb2
added a commit
to superfly/flyctl
that referenced
this pull request
Mar 25, 2024
* Fix pg import Relies on fly-apps/postgres-importer#7, but basically, we just specify the machine ID of the machine to connect to when importing, rather than relying on `<appname>.internal` not giving us the ID of the ephemeral machine. * Choose PG leader's machine ID Also use AppCompact to save a round trip call to web * Make sure to include the app name in the flaps client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of trying to connect to
<appname>.internaland hoping that SkipDNSRegistration does the job, we can just guarantee that importing works by connecting to a known postgres machine (<machine_id>.vm.<appname>.internal)Related to:
superfly/flyctl#3401