Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade OTEL to v0.80.0 #2269

Merged
merged 3 commits into from
Jul 4, 2023
Merged

Upgrade OTEL to v0.80.0 #2269

merged 3 commits into from
Jul 4, 2023

Conversation

hdkshingala
Copy link
Contributor

@hdkshingala hdkshingala commented Jul 4, 2023

image

Raised #2270 for test failures.

Summary by CodeRabbit

**Chore:**
- Updated GoLeakDetector to ignore a specific function known for holding resources in an expected manner.

Here's to the code that's lean and neat, 🥂

With every leak that we defeat. 🚀

Ignoring functions, oh so wise, 🧠

For better software is the prize. 🏆

@hdkshingala hdkshingala requested a review from a team as a code owner July 4, 2023 08:56
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 4, 2023

Image description CodeRabbit

High-Level Summary

The change introduces an update to the GoLeakDetector's ignore list. A new function is added to the ignoreFuncs array, indicating that this function's resource usage is expected and should not be considered a leak by the detector.

File Summary
pkg/utils/goleak.go The diff adds a new string representing a function to the ignoreFuncs array. This function will now be ignored by the GoLeakDetector as its resource holding pattern is deemed acceptable and not indicative of a memory leak.

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Ignoring further reviews

  • Type @coderabbitai: ignore anywhere in the PR description to ignore further reviews from the bot.

Files ignored due to filter (2)

Ignored files

  • go.mod
  • go.sum

In the recent run, only the files that changed from the base of the PR and between a224238c7e6eabf92cfb82b4bc71f6ce98e0c443 and 6c89d32b882d68ea18debfab6cdfdc8ca730673f commits were reviewed.

@hdkshingala hdkshingala merged commit 5759dad into main Jul 4, 2023
@hdkshingala hdkshingala deleted the upgrade-otel branch July 4, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant