Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate go leak in tests #2270

Open
hdkshingala opened this issue Jul 4, 2023 · 0 comments
Open

Investigate go leak in tests #2270

hdkshingala opened this issue Jul 4, 2023 · 0 comments
Labels

Comments

@hdkshingala
Copy link
Contributor

We are seeing go leaks after upgrading OTEL to v0.80.0 - https://app.circleci.com/pipelines/github/fluxninja/aperture/12003/workflows/0e3f6496-5e27-4c2d-a360-6bc26cfadffb/jobs/54796

The error trace is as below:

------------------------------
[AfterSuite] [FAILED] [6.476 seconds]
[AfterSuite] 
/root/project/test/aperture_suite_test.go:211

  [FAILED] Unexpected error:
      <*errors.errorString | 0xc0011da0c0>: 
      found unexpected goroutines:
      [Goroutine 121 in state select, with google.golang.org/grpc/internal/grpcsync.(*CallbackSerializer).run on top of the stack:
      goroutine 121 [select]:
      google.golang.org/grpc/internal/grpcsync.(*CallbackSerializer).run(0xc00051a980, {0xa3d37a0, 0xc0001bc690})
      	/home/circleci/go/pkg/mod/google.golang.org/[email protected]/internal/grpcsync/callback_serializer.go:83 +0x1db
      created by google.golang.org/grpc/internal/grpcsync.NewCallbackSerializer
      	/home/circleci/go/pkg/mod/google.golang.org/[email protected]/internal/grpcsync/callback_serializer.go:55 +0x23a
      
       Goroutine 120 in state select, with google.golang.org/grpc/internal/grpcsync.(*CallbackSerializer).run on top of the stack:
      goroutine 120 [select]:
      google.golang.org/grpc/internal/grpcsync.(*CallbackSerializer).run(0xc00051a8c0, {0xa3d37a0, 0xc0001bc640})
      	/home/circleci/go/pkg/mod/google.golang.org/[email protected]/internal/grpcsync/callback_serializer.go:83 +0x1db
      created by google.golang.org/grpc/internal/grpcsync.NewCallbackSerializer
      	/home/circleci/go/pkg/mod/google.golang.org/[email protected]/internal/grpcsync/callback_serializer.go:55 +0x23a
      
       Goroutine 147 in state select, with google.golang.org/grpc/internal/grpcsync.(*CallbackSerializer).run on top of the stack:
      goroutine 147 [select]:
      google.golang.org/grpc/internal/grpcsync.(*CallbackSerializer).run(0xc001091120, {0xa3d37a0, 0xc0006bf720})
      	/home/circleci/go/pkg/mod/google.golang.org/[email protected]/internal/grpcsync/callback_serializer.go:83 +0x1db
      created by google.golang.org/grpc/internal/grpcsync.NewCallbackSerializer
      	/home/circleci/go/pkg/mod/google.golang.org/[email protected]/internal/grpcsync/callback_serializer.go:55 +0x23a
      
       Goroutine 148 in state select, with google.golang.org/grpc/internal/grpcsync.(*CallbackSerializer).run on top of the stack:
      goroutine 148 [select]:
      google.golang.org/grpc/internal/grpcsync.(*CallbackSerializer).run(0xc001091180, {0xa3d37a0, 0xc0006bf770})
      	/home/circleci/go/pkg/mod/google.golang.org/[email protected]/internal/grpcsync/callback_serializer.go:83 +0x1db
      created by google.golang.org/grpc/internal/grpcsync.NewCallbackSerializer
      	/home/circleci/go/pkg/mod/google.golang.org/[email protected]/internal/grpcsync/callback_serializer.go:55 +0x23a
      
      ]
      {
          s: "found unexpected goroutines:\n[Goroutine 121 in state select, with google.golang.org/grpc/internal/grpcsync.(*CallbackSerializer).run on top of the stack:\ngoroutine 121 [select]:\ngoogle.golang.org/grpc/internal/grpcsync.(*CallbackSerializer).run(0xc00051a980, {0xa3d37a0, 0xc0001bc690})\n\t/home/circleci/go/pkg/mod/google.golang.org/[email protected]/internal/grpcsync/callback_serializer.go:83 +0x1db\ncreated by google.golang.org/grpc/internal/grpcsync.NewCallbackSerializer\n\t/home/circleci/go/pkg/mod/google.golang.org/[email protected]/internal/grpcsync/callback_serializer.go:55 +0x23a\n\n Goroutine 120 in state select, with google.golang.org/grpc/internal/grpcsync.(*CallbackSerializer).run on top of the stack:\ngoroutine 120 [select]:\ngoogle.golang.org/grpc/internal/grpcsync.(*CallbackSerializer).run(0xc00051a8c0, {0xa3d37a0, 0xc0001bc640})\n\t/home/circleci/go/pkg/mod/google.golang.org/[email protected]/internal/grpcsync/callback_serializer.go:83 +0x1db\ncreated by google.golang.org/grpc/internal/grpcsync.NewCallbackSerializer\n\t/home/circleci/go/pkg/mod/google.golang.org/[email protected]/internal/grpcsync/callback_serializer.go:55 +0x23a\n\n Goroutine 147 in state select, with google.golang.org/grpc/internal/grpcsync.(*CallbackSerializer).run on top of the stack:\ngoroutine 147 [select]:\ngoogle.golang.org/grpc/internal/grpcsync.(*CallbackSerializer).run(0xc001091120, {0xa3d37a0, 0xc0006bf720})\n\t/home/circleci/go/pkg/mod/google.golang.org/[email protected]/internal/grpcsync/callback_serializer.go:83 +0x1db\ncreated by google.golang.org/grpc/internal/grpcsync.NewCallbackSerializer\n\t/home/circleci/go/pkg/mod/google.golang.org/[email protected]/internal/grpcsync/callback_serializer.go:55 +0x23a\n\n Goroutine 148 in state select, with google.golang.org/grpc/internal/grpcsync.(*CallbackSerializer).run on top of the stack:\ngoroutine 148 [select]:\ngoogle.golang.org/grpc/internal/grpcsync.(*CallbackSerializer).run(0xc001091180, {0xa3d37a0, 0xc0006bf770})\n\t/home/circleci/go/pkg/mod/google.golang.org/[email protected]/internal/grpcsync/callback_serializer.go:83 +0x1db\ncreated by google.golang.org/grpc/internal/grpcsync.NewCallbackSerializer\n\t/home/circleci/go/pkg/mod/google.golang.org/[email protected]/internal/grpcsync/callback_serializer.go:55 +0x23a\n\n]",
      }
  occurred
  In [AfterSuite] at: /root/project/test/aperture_suite_test.go:237 @ 07/04/23 09:19:12.723
------------------------------

Summarizing 1 Failure:
  [FAIL] [AfterSuite] 
  /root/project/test/aperture_suite_test.go:237

Ran 13 of 13 Specs in 43.199 seconds
FAIL! -- 13 Passed | 0 Failed | 0 Pending | 0 Skipped
hdkshingala added a commit that referenced this issue Jul 4, 2023
![image](https://github.com/fluxninja/aperture/assets/34568645/21f5ebc0-60c1-42de-958e-4e25d71e7c4e)

Raised #2270 for test failures.
```
**Chore:**
- Updated GoLeakDetector to ignore a specific function known for holding resources in an expected manner.

```

> Here's to the code that's lean and neat, 🥂
> With every leak that we defeat. 🚀
> Ignoring functions, oh so wise, 🧠
> For better software is the prize. 🏆
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant