version: update builds and CI to go 1.22 #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: the upstream scheduler-plugins is now using 1.22.0. Solution: we should do the same. Signed-off-by: vsoch <[email protected]>
Problem: boost_system is no longer required (or built into the base image) Solution: remove it. Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
|
I think what is happening are upstream changes (many in the last 2 months) https://github.com/kubernetes-sigs/scheduler-plugins/commits/master/ so fluence builds but isn't functioning as expected. I'm too zonked to debug now or soon, but if someone wants to jump on it, please do! |
The hack build images is changing too often to make it easy to maintain, and we anticipated this. Instead we can keep the build logic in our Makefile. Signed-off-by: vsoch <[email protected]>
There was a change upstream that switched the kube-scheduler back to being in bin (in the Dockerfile) but the corresponding manifest was not updated. Signed-off-by: vsoch <[email protected]>
cmisale
approved these changes
Sep 3, 2024
|
Thanks @cmisale ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: the upstream scheduler-plugins is now using 1.22.0.
Solution: we should do the same.
Other Changes: