chore: rename utils to podspec #78
Conversation
Problem: the "utils" package in fluence does not describe what it does, and these functions are hard for the developer to find. Solution: rename to podspec to reflect this is what the package is oriented to do. Signed-off-by: vsoch <[email protected]>
Problem: LD_LIBRARY_PATH is not defined and is issuing a warning during build. Solution: remove the variable - I have confirmed it is not defined in the base image. Signed-off-by: vsoch <[email protected]>
Problem: the container builds are using an old Go, 1.19 Solution: update to 1.21 to match the rest of CI recipes. Signed-off-by: vsoch <[email protected]>
vsoch
force-pushed
the
chore/reorganize-utils
branch
from
f9f0d18 to
9dd4198
Compare
|
Amazing - I just moved a change between commits and I didn't break anything. There must be a lot of pigs flying outside today. |
|
No rush to review these @milroy - please take care of the 🔥 first. |
|
Thanks @cmisale ! Is it OK if I ping you for future reviews? I wasn't sure if you had the bandwidth since the project was coming to a close. |
|
Absolutely! I'm incredibly quiet but I follow. I always take a look at every PR added me as reviewer even tho some are very big and cannot look at everything with the care I'd like.. |
|
Thank you 🙏 I didn't know! I apologize for not asking for your review before - I didn't want to burden you. |
|
I'll try to keep them as small / scoped as possible - that first one was... 🤯 |
|
No need to apologize :| I've been absent for some time, so it's totally understandable. And haha yes, the first one was huge lol |
Problem: the "utils" package in fluence does not describe what it does, and these functions are hard for the developer to find.
Solution: rename to podspec to reflect this is what the package is oriented to do.
This will close #77