[monorepo] add CI stage document for tests #4154
Conversation
yjbanov
changed the title
| /// Check run update recorded successfully in the respective CI stage. | ||
| ok, |
There was a problem hiding this comment.
Nit: maybe add:
/// It is OK to evaluate returned results for stage completeness
| /// The check run was found in the specified CI stage but the update failed. | ||
| failed, |
There was a problem hiding this comment.
Higher up:
log.info('$logCrumb: staging document not found for $transaction');
result: StagingConclusionResult.failed,
So the check run wasn't found either; but there was an internal error. Do we want that visibility here?
There was a problem hiding this comment.
If the document wasn't found, how can we know whether the check run would be found in the doc or not?
There was a problem hiding this comment.
I'm assuming in a multi-staged world all documents are created and available? If so, lets note that somewhere so its clear "this is a failure because we expect the document to be there". Today that's not the case.
There was a problem hiding this comment.
Either that or we have another conclusion. The comment is "the check run was found" - it wasn't because we don't have the document.
There was a problem hiding this comment.
Ah, gotcha. Changed it to internalError and updated the docs.
| StagingConclusion stagingConclusion, | ||
| RepositorySlug slug, |
There was a problem hiding this comment.
Do you need stagingConclusion if its "close successful"?
yjbanov
added
the
autosubmit
|
Still LGTM |
fusionEngineBuildcompletes, create a firestore document for thefusionTestsCI stage tasks.This PR does not yet alter the MQ guard behavior. I'd like to debug the document behavior first.
Progress towards flutter/flutter#159898